Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a lottie animation loader to the website #594

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

PulkitShubham
Copy link
Contributor

@PulkitShubham PulkitShubham commented Oct 19, 2024


PR Title

#540 Lottie Loader Implementation solved

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

This pull request aims to implement a Lottie animation loader that displays while the main content of the webpage is loading. The loader is centered on the screen and fades out smoothly once the page is fully loaded, enhancing the user experience during loading times.

Screenshots / Videos (if applicable)

Before:

  • The webpage displayed no loader during loading, leading to a blank screen that might confuse users.

After:

  • A visually appealing Lottie loader appears at the center of the screen while the content is loading, providing a clear indication that the page is in the process of loading.

image

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

The loader was created using the Lottie web library, which allows for scalable vector animations. The animation URL used is a publicly available example. The implementation includes a fade-in effect for the main content and prevents scrolling while the loader is visible. No additional issues were encountered during the implementation.

Thank you for reviewing my pull request!


Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 2:07pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @PulkitShubham! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit c9aeb99
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/67150eb9a62048000869faea
😎 Deploy Preview https://deploy-preview-594--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PulkitShubham
Copy link
Contributor Author

@swaraj-das Kindly review my PR I've worked quite hard to get an animated loader issue no #540

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

index.html Outdated Show resolved Hide resolved
@PulkitShubham
Copy link
Contributor Author

@swaraj-das I have rectified the issue and added Loader.js and Loader.css files

@swaraj-das swaraj-das merged commit 2c91895 into swaraj-das:main Oct 21, 2024
5 checks passed
Copy link

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants