-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA enabled #591
PWA enabled #591
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @mohammedanaf! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
✅ Deploy Preview for collect-your-gamingtools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@swaraj-das I have mentioned the files which I modified in the |
Hi there! This issue is still open. We are looking forward to your response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @swaraj-das I didn't know anything about PWA at this time but according to copilot it is approved
Once the pull request gets merged and changes are reflected, this is how it's gonna look @swaraj-das @AnitSarkar123 |
Ok as you said |
Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨ |
Pull Request Format
Made the site a Progressive Web Application(PWA)
Issue #572 : [Feature] Enable PWA for the site solved
Type of PR
Description
This pull request aims to make the website a PWA so users can download it into their smartphones, tables, laptops or desktops and access it directly through the app icon on the system. It also provides the capability of offline viewing without compromising in quality or quantity.
Screenshots / Videos (if applicable)
Since PWA is only supported in HTTPS connection, there is no screenshot or video showcasing the functionality.
Checklist
Additional Context
I have modified
index.html
file with an inline comment to linkmanifest.json
. I have also added two other files namedmanifest.json
andservice-worker.js
for enabling PWA. I have also added a service worker script inscript.js
at the bottom with an inline comment to detectservice-worker.js
file in the root of the folder. I also have resizedlogo.png
to 192x192 and 512x512 format for app icon in different screen sizes.Thank you for reviewing my pull request!