Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA enabled #591

Merged
merged 1 commit into from
Oct 20, 2024
Merged

PWA enabled #591

merged 1 commit into from
Oct 20, 2024

Conversation

mohammedanaf
Copy link
Contributor

Pull Request Format

Made the site a Progressive Web Application(PWA)

Issue #572 : [Feature] Enable PWA for the site solved

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

This pull request aims to make the website a PWA so users can download it into their smartphones, tables, laptops or desktops and access it directly through the app icon on the system. It also provides the capability of offline viewing without compromising in quality or quantity.

Screenshots / Videos (if applicable)

Since PWA is only supported in HTTPS connection, there is no screenshot or video showcasing the functionality.

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

I have modified index.html file with an inline comment to link manifest.json. I have also added two other files named manifest.json and service-worker.js for enabling PWA. I have also added a service worker script in script.js at the bottom with an inline comment to detect service-worker.js file in the root of the folder. I also have resized logo.png to 192x192 and 512x512 format for app icon in different screen sizes.

Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 5:39pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @mohammedanaf! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 9ed625f
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/6713eebbf367500008178f4f
😎 Deploy Preview https://deploy-preview-591--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mohammedanaf
Copy link
Contributor Author

mohammedanaf commented Oct 19, 2024

@swaraj-das I have mentioned the files which I modified in the Additional Content part of PR

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link
Collaborator

@AnitSarkar123 AnitSarkar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @swaraj-das I didn't know anything about PWA at this time but according to copilot it is approved

@mohammedanaf
Copy link
Contributor Author

Once the pull request gets merged and changes are reflected, this is how it's gonna look @swaraj-das @AnitSarkar123

PWA-enabled

https://in.pinterest.com

@AnitSarkar123
Copy link
Collaborator

Ok as you said

@AnitSarkar123 AnitSarkar123 merged commit d33ded2 into swaraj-das:main Oct 20, 2024
6 of 7 checks passed
Copy link

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants