Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PrValidator github workflow #536

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

ygowthamr
Copy link
Contributor

What i have done :

  • Solved Adding GitHub action workflow for PR validation

Fixes #530

@swaraj-das
Pls add me labels like gssoc-extd,level3,hacktoberfest.

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 3:33pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @ygowthamr! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 21d146b
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/67112e4e0ceb360008bcb1db
😎 Deploy Preview https://deploy-preview-536--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AnitSarkar123
Copy link
Collaborator

@ygowthamr 🤦🤦🤦🤦🤦🤦🤦 what said to you in #530 I said to you just fix it .

@ygowthamr
Copy link
Contributor Author

ygowthamr commented Oct 17, 2024

@AnitSarkar123

The screen short which it is there in the issue is not from your repo it is from different repo i just kept it for reference. There is no such file like PRValidator.yml in your repo

@AnitSarkar123
Copy link
Collaborator

@AnitSarkar123

The screen short which it is there in the issue is not from your repo it is from different repo i just kept it for reference. There is no such file like PRValidator.yml in your repo

@ygowthamr sorry for that
Screenshot_2024-10-17-21-17-20-794_com.github.android.jpg

I think you are saying about second file of the part

@ygowthamr
Copy link
Contributor Author

@AnitSarkar123

Ok no problem merge my pr

@AnitSarkar123
Copy link
Collaborator

@AnitSarkar123

Ok no problem merge my pr

@ygowthamr sorry we don't required this feature I said you about that.

@ygowthamr
Copy link
Contributor Author

@AnitSarkar123
Its your mistake right? you need to check properly before assigning. After assigning and after making pull request you should not say like this

@AnitSarkar123
Copy link
Collaborator

@ygowthamr ok I merge it

@AnitSarkar123 AnitSarkar123 merged commit 8a08932 into swaraj-das:main Oct 17, 2024
7 checks passed
Copy link

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

@ygowthamr
Copy link
Contributor Author

@AnitSarkar123
Thank you

@AnitSarkar123
Copy link
Collaborator

@ygowthamr ok I merge it

If you can solve the error in next pr then I will give you level3 in that pr

@ygowthamr
Copy link
Contributor Author

ygowthamr commented Oct 17, 2024

@AnitSarkar123
Can you tell me exactly which error
Give me atleast level2 for this

@ygowthamr
Copy link
Contributor Author

@AnitSarkar123

Can you tell me exactly which error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding github action workflow for PR validation
2 participants