Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added express rate limit #533

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

AyushSharma72
Copy link
Contributor

Pull Request Format

PR Title

Issue #481 solved

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

i have added a middle ware it limit the number if request made to the api
benefit
reduce load on the signin api
prevent bots attack

Screenshots / Videos (if applicable)

login with invalid credentials
Screenshot (277)

after 5 times the api will not process the request from the ip address for 5 minutes
Screenshot (278)

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

[Provide any additional context about the changes, such as specific challenges you faced or decisions you made. This can help reviewers understand the rationale behind your changes.]

Thank you for reviewing my pull request!

please add gssoc-ext and level3 before merge @swaraj-das

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 3:22pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @AyushSharma72! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit c8ef193
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/67112bae9de9330008bf108b
😎 Deploy Preview https://deploy-preview-533--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AyushSharma72 AyushSharma72 mentioned this pull request Oct 17, 2024
8 tasks
Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@AyushSharma72
Copy link
Contributor Author

AyushSharma72 commented Oct 18, 2024

Hi there! This issue is still open. We are looking forward to your response. Assignees: None

Please merge this PR @swaraj-das

Copy link
Collaborator

@AnitSarkar123 AnitSarkar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok good

@AnitSarkar123 AnitSarkar123 merged commit ad6feb6 into swaraj-das:main Oct 18, 2024
7 checks passed
Copy link

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

@AyushSharma72
Copy link
Contributor Author

Ok good

But it was level2 issue please add level2 @swaraj-das

@AnitSarkar123
Copy link
Collaborator

Ok good

But it was level2 issue please add level2 @swaraj-das

But issue have label1

@AnitSarkar123
Copy link
Collaborator

AnitSarkar123 commented Oct 18, 2024

Ok good

But it was level2 issue please add level2 @swaraj-das

You also don't use cloudfare or redis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants