Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate Apple iOS sign in & fix styles of the Testimonials #507

Merged
merged 8 commits into from
Nov 9, 2024

Conversation

REHAN-18
Copy link
Contributor

@REHAN-18 REHAN-18 commented Oct 16, 2024

Issue #499 : Integrate Apple iOS Login & Style Fixes solve in Testimonials

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

This pull request aims to integrate Apple iOS login functionality into the signup form and improve various styles for better user experience. The integration allows users to sign up using their Apple ID, enhancing security and user convenience. &
change the Testimonials style now they look aesthetic

Screenshots / Videos (if applicable)

Before:

before Screenshot 2024-10-17 at 1 03 37 AM

After:

after Screenshot 2024-10-17 at 12 51 49 AM

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

Integrating Apple Sign-In required setting up the Apple Developer account and configuring the necessary settings for client ID and redirect URI. During the style fixes, I focused on aligning input fields and buttons for a cleaner layout, improving the overall aesthetics of the signup page. I faced some challenges with cross-browser compatibility but have tested the final version across major browsers.
Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 0:08am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @REHAN-18! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 62669e5
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/672f50c1bf71a500080a8992
😎 Deploy Preview https://deploy-preview-507--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@swaraj-das
Copy link
Owner

@REHAN-18 Make the testimonial section toggle with light and dark mode.

@REHAN-18
Copy link
Contributor Author

@swaraj-das ok !!!

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@REHAN-18
Copy link
Contributor Author

@swaraj-das done bro!!

@swaraj-das
Copy link
Owner

@REHAN-18

image
The navbar collapsed. Fix it.

@REHAN-18
Copy link
Contributor Author

REHAN-18 commented Oct 19, 2024

@swaraj-das ok trying to fix!

@REHAN-18
Copy link
Contributor Author

@swaraj-das bro fix nav bar issue as well as testimonial section toggle with light and dark mode.
Screenshot 2024-10-19 at 11 44 23 AM
Screenshot 2024-10-19 at 11 44 27 AM

check it! I have modified the readme Added gssoc fest logo ....

@REHAN-18
Copy link
Contributor Author

REHAN-18 commented Oct 19, 2024 via email

@REHAN-18
Copy link
Contributor Author

Kindly merge this PR @swaraj-das as I have done as you asked and I am very grateful for this contribution

@REHAN-18
Copy link
Contributor Author

@swaraj-das done bro SEE THIS MERGE MY PR as I fullfill all ur request & made a bugs free (resolved the issue )

@REHAN-18
Copy link
Contributor Author

@swaraj-das BRO WHY RE U ignoring pr ...its take hardwork to raise a issue then raise a pr...we put effort to implement the the fix the bugs but ur not looking at the pr !!!

@REHAN-18
Copy link
Contributor Author

@swaraj-das bro pls check this project their no conflict pls its I ve solve ur issue As you sAid

@REHAN-18
Copy link
Contributor Author

@swaraj-das bro I ve raise this pr earlier but ur ignoring it >>> I ve done as you said merge it pls Issue #499
its take hardwork to do but you r ignoring it

@REHAN-18
Copy link
Contributor Author

REHAN-18 commented Nov 9, 2024

@MastanSayyad sir pls see this its almost 3 week but the maintainer is ignoring pr ....I ve done resolve the issue but it's not merged yet issue #499 & give level label also

@MastanSayyad MastanSayyad merged commit e59c432 into swaraj-das:main Nov 9, 2024
6 checks passed
Copy link

github-actions bot commented Nov 9, 2024

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

@REHAN-18
Copy link
Contributor Author

REHAN-18 commented Nov 9, 2024

@MastanSayyad thanks sir!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants