Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Sign up button & made Responsive #256

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Conversation

4F24L
Copy link
Contributor

@4F24L 4F24L commented Oct 9, 2024

Sign up button & made Responsive

Type of PR

Add X in the box to specify the improvement type.

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

  • I redesign the signup page. I made the page fit in 100Vh, so the user will not have to scroll to sign up. sign up button style changed. And was The page made responsive for smaller screens.

Screenshots / Videos (if applicable)

Before :

  • Sign up button issue.
  • Sign up Page overflow [ scroll mode ]
  • Not responsive.

image

After ✅ :

  • Sign up button issue fixed.
  • Sign up page overflow [ scroll mode ] Fixed.
  • Made responsive.

image

Checklist

Add X in the box to specify.

  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

Please add level 3 to this PR. I changed the button, the page, and the form and made responsive for smaller screens

Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 5:00am

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 85e59dc
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/6708b1065ca14a0008758c19
😎 Deploy Preview https://deploy-preview-256--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@4F24L
Copy link
Contributor Author

4F24L commented Oct 9, 2024

@4F24L
Copy link
Contributor Author

4F24L commented Oct 11, 2024

Hey @swaraj-das , Can you review this ?!

Please add level 3 to this PR. I changed the button, the page, and the form and made responsive for smaller screens

@swaraj-das
Copy link
Owner

Hey @swaraj-das , Can you review this ?!

Please add level 3 to this PR. I changed the button, the page, and the form and made responsive for smaller screens

It's not sufficient for Level 3. You need to work on more complex tasks to truly earn the Level 3 label. Understand?

@swaraj-das swaraj-das merged commit 4fe641c into swaraj-das:main Oct 11, 2024
6 checks passed
@4F24L
Copy link
Contributor Author

4F24L commented Oct 11, 2024

Hey @swaraj-das , Can you review this ?!
Please add level 3 to this PR. I changed the button, the page, and the form and made responsive for smaller screens

It's not sufficient for Level 3. You need to work on more complex tasks to truly earn the Level 3 label. Understand?

Thanks, Understood !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Sign Up page Styling Issue
2 participants