Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue #181. added nav bar to login and signup pages #237

Closed
wants to merge 10 commits into from

Conversation

manikdamle
Copy link

@manikdamle manikdamle commented Oct 9, 2024

Pull Request Format

PR Title

Issue#181 : [BUG] Add nav bar and footer to sign up and login pages solved

Type of PR

  • Bug fix

Description

Added nav bar to login and signup pages

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 2:41am

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 44b195b
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/6708903a5ade4a0008096f3e
😎 Deploy Preview https://deploy-preview-237--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@manikdamle
Copy link
Author

Hey @swaraj-das! Pls check and merge

@manikdamle
Copy link
Author

@swaraj-das pls review

@swaraj-das
Copy link
Owner

@manikdamle The login page looks decent, but there’s room for improvement. The sign-up page needs more attention as it requires significant enhancements. Additionally, both the footer and the navbar don’t look quite right and could use redesigning to improve the overall user experience.

@manikdamle
Copy link
Author

@swaraj-das Ok will do so.

@swaraj-das swaraj-das closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants