-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twitter logo Update #114
Twitter logo Update #114
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@swaraj-das Please add the following labels:
|
@swaraj-das Please review this PR too. You have reviewed my other PR, but this one is pending. Also reminder to add level tag in the issue #105. |
@AnitSarkar123, Please review this PR. Also look into the issue that occurred in PR #127. Due to wrong issue of labels, the PR is not being reflected on the GSSoC leaderboard. I have raised 2 issues on this repository and the later one has been merged, but this one is yet pending. |
@swaraj-das Please review this PR and give a label in issue #105 |
@rajdeepchakraborty-rc Merge conflicts. Please resolve it. |
@swaraj-das Ok |
Also please assign a level to the issue #105 |
@swaraj-das I have synced my branch and resolved the merge conflict. Please review it. |
Ok I noticed that the zoom effect on hover has been removed. Please wait a while. I will add that |
Apart from adding the updated X[Twitter] logo, I have also added the following hover animation on the Social Icons: Hover.Animation.on.Social.Icons.mp4Please review the PR at your earliest. |
@swaraj-das Also a friendly reminder from the GSSoC community announcements: Please issue the correct tags. Also issue level tag in the corresponding issue #105. Would appreciate a level2 tag since I have updated the code and also added an extra hover animation to the project. |
@swaraj-das reminder to review the PR. Please try to review it soon, as otherwise I would have to face a conflict again. |
@AnitSarkar123 please assign the PR to me and issue the required labels as stated before. |
@AnitSarkar123 Please remove the gssoc-extd label as it is a wrong label. |
@AnitSarkar123 I have also informed this to swaraj, but I am also informing you, the corresponding issue of this PR does not have the level tag assigned. Please do so and close the Issue #105 of this PR. |
Pull Request Format
Updated X(Twitter) Logo added
Issue #105 : Update X[Twitter] Logo. [SOLVED]
Type of PR
Description
This pull request aims to replace the X (Twitter) logo with the updated version to eliminate any ambiguity for users.
Screenshots / Videos (if applicable)
Before:
After:
Checklist
Additional Context
I had to face the challenge of the newly added X(Twitter) Icon not having the hover zoom animation. Thus, had to change the CSS a bit to solve the issue.
Thank you for reviewing my pull request!