Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata XML enumerators part 2 #91

Merged
merged 16 commits into from
Dec 23, 2024
Merged

Conversation

sveinungf
Copy link
Owner

@sveinungf sveinungf commented Dec 22, 2024

Preparations for #63

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 94.35737% with 18 lines in your changes missing coverage. Please review.

Project coverage is 91.77%. Comparing base (4d381d0) to head (203f6f3).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
SpreadCheetah/MetadataXml/WorksheetRelsXml.cs 87.09% 1 Missing and 3 partials ⚠️
SpreadCheetah/SpreadsheetBuffer.cs 71.42% 2 Missing and 2 partials ⚠️
SpreadCheetah/MetadataXml/VmlDrawingNoteXml.cs 93.18% 0 Missing and 3 partials ⚠️
SpreadCheetah/MetadataXml/WorksheetEndXml.cs 66.66% 0 Missing and 3 partials ⚠️
SpreadCheetah/MetadataXml/CommentsXml.cs 96.42% 1 Missing ⚠️
SpreadCheetah/MetadataXml/DrawingImageXml.cs 97.29% 0 Missing and 1 partial ⚠️
SpreadCheetah/MetadataXml/WorkbookRelsXml.cs 97.05% 0 Missing and 1 partial ⚠️
SpreadCheetah/MetadataXml/WorkbookXml.cs 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   90.56%   91.77%   +1.21%     
==========================================
  Files         153      152       -1     
  Lines        5553     5556       +3     
  Branches      989      930      -59     
==========================================
+ Hits         5029     5099      +70     
- Misses        211      214       +3     
+ Partials      313      243      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 22, 2024

Test Results

     9 files  ±0       9 suites  ±0   12m 48s ⏱️ - 3m 18s
 4 536 tests +1   4 536 ✅ +1  0 💤 ±0  0 ❌ ±0 
13 302 runs  +3  13 302 ✅ +3  0 💤 ±0  0 ❌ ±0 

Results for commit 203f6f3. ± Comparison against base commit 4d381d0.

♻️ This comment has been updated with latest results.

@sveinungf sveinungf merged commit b26c575 into main Dec 23, 2024
4 checks passed
@sveinungf sveinungf deleted the dev/metadata-xml-enumerators-part2 branch January 11, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant