updated cmake min version to 3.18 #970
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This tiny PR attempts to update the minimum version of CMake required to compile DAGMC.
I believe this would be useful for two other PRs where @ahnaf-tahmid-chowdhury and @bam241 have both been keen to update the version of CMake.
#969
#966
Motivation and Context
Why is this change required? What problem does it solve?
Packaging issues solved
Changes
What kind of change does this PR introduce? (Bug fix, feature, documentation update...)
Update to Cmake version used
Behavior
What is the current behavior? What is the new behavior?
Compile with cmake 3.1 or above -> compile with cmake 3.18 or above
Other Information
Other relevant information to this pull request.
Ubuntu 22.04 has CMake version 3.22.1 and Ubuntu 24.04 has CMake version 3.27.4 so this bum to CMake 3.18 is easily covered by the two latest stable releases of Ubuntu
Changelog file
Done