Streamline dependencies of docker CI images Part 2 #952
Conversation
|
Bad luck. It appears that HDF5 requires CMake 3.18 as the minimum version for support in the |
Hmmm.... I guess we could drop 20.04 support? We're only a few weeks away from 24.04 being released.... |
| @@ -59,7 +59,7 @@ runs: | |||
| }}-double_down_${{ | |||
| inputs.double_down_version | |||
| }} | |||
| stages: base, external_deps, hdf5, moab, dagmc | |||
| stages: base, external_deps, dagmc | |||
| server-stage: dagmc_test | |||
There was a problem hiding this comment.
How it works? I have noticed it just caching everything. And tests are already passed on the final stage. Maybe I have misconfigured something?
There was a problem hiding this comment.
What do you expect to be different?
| @@ -75,7 +74,7 @@ jobs: | |||
| uses: firehed/multistage-docker-build-action@v1 | |||
| with: | |||
| repository: ${{ env.image_base_tag }} | |||
| stages: base, external_deps, hdf5, moab, dagmc | |||
| stages: base, external_deps, dagmc, final | |||
| server-stage: dagmc_test | |||
There was a problem hiding this comment.
Sorry, I'd like to ask my previous question here. I believe the final stage could be set as server-stage, and dagmc_test may be moved to stages part.
There was a problem hiding this comment.
Should I put dagmc_test to stages and final to server-stage?
There was a problem hiding this comment.
I don't think it makes a lot of different for our purposes.
There was a problem hiding this comment.
Then we are good to go.
There was a problem hiding this comment.
Thanks @ahnaf-tahmid-chowdhury - this creates a lot of different packages. At some point we'll want to clean them up and remove the deprecated ones.
|
Please explain or make an issue. I will try to solve that accordingly. |
Description
This PR aims to streamline the dependencies of Docker CI images by removing autoconf and extra docker stages
moabandhdf5, and merging them into theexternal_stagestage. HDF5 will now be built using CMake instead of autoconf.Changes Made
moabandhdf5stages into theexternal_stagestage.