Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Double Down to 1.1.0 #932

Closed
wants to merge 3 commits into from
Closed

Conversation

ahnaf-tahmid-chowdhury
Copy link
Member

Update Double Down to 1.1.0

Please note: This PR sets DOUBLE_DOWN=ON by default

@ahnaf-tahmid-chowdhury ahnaf-tahmid-chowdhury changed the title dd 1.1.0 Update Double Down to 1.1.0 Dec 20, 2023
@gonuke
Copy link
Member

gonuke commented Feb 5, 2024

I don't think this has all the logic quite right for when we use double_down_version and when we use double_down.

Perhaps contrary to some previous advice, I think we need to pass both as build-args. One let's us update and test newer versions of Double Down and one lets us decide whether to build with it or not. I think we may have also decided to always test/build with DD now.

@ahnaf-tahmid-chowdhury
Copy link
Member Author

Should I follow this PR or close this one as I think I am working on PR #929? As you have mentioned to do the both test, I say, according to the current stage of the PR #929, we can do the build both just adding a single word to the Docker build workflow:

matrix:
    double_down_version : [
        off, 
        v1.1.0
    ]

@gonuke
Copy link
Member

gonuke commented Feb 8, 2024

I forgot about #929 and agree that maybe we should close/withdraw this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants