Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 for CI #747

Merged
merged 10 commits into from
Jul 8, 2021
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions CI/Dockerfile_0_base
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,29 @@ SHELL ["/bin/bash", "-c"]

# Update core packages
RUN apt-get -y update; \
apt-get -y install autoconf clang cmake g++ gcc gfortran git libblas-dev \
libhdf5-dev liblapack-dev libpython2.7-dev libtool libeigen3-dev\
python-numpy python-pip python-setuptools wget; \
pip install cython
apt-get -y install autoconf \
clang \
cmake \
g++ \
gcc \
gfortran \
git \
libblas-dev \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but I don't think we need BLAS/LAPACK anymore...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about this, issuing a news PR for it !
(maybe it could be a good test for our docker building/testing PR)

libhdf5-dev \
liblapack-dev \
libtool \
libeigen3-dev\
python3-numpy \
python3 \
python3-pip \
python3-setuptools \
python3-dev \
libpython3-dev \
wget; \
update-alternatives --install /usr/bin/python python /usr/bin/python3 10; \
update-alternatives --install /usr/bin/pip pip /usr/bin/pip3 10; \
pip install cython;


# Copy scripts to docker image
RUN mkdir -p /root/etc/
Expand Down
12 changes: 12 additions & 0 deletions news/PR-0747.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
**Added:** None

**Changed:**
- retiring python2 in CI

**Deprecated:** None

**Removed:** None

**Fixed:** None

**Security:** None