Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

localize git submodule stuff to only when BUILD_UWUW #968

Merged
merged 3 commits into from
Dec 12, 2024
Merged

localize git submodule stuff to only when BUILD_UWUW #968

merged 3 commits into from
Dec 12, 2024

Conversation

gonuke
Copy link
Member

@gonuke gonuke commented Dec 3, 2024

Description

Fixes #967

Changes

Localize the invocation of git submodules to occur only when BUILD_UWUW is true.

pshriwise
pshriwise reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just thinking about this yesterday! Thanks for this @gonuke!

nuclearkevin
nuclearkevin approved these changes Dec 3, 2024
View reviewed changes
Copy link

@nuclearkevin nuclearkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gonuke! I've tested these changes in Cardinal and can confirm that it solves the CIVET issue.

pshriwise
pshriwise approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me too.

Not sure what to do about the Windows CI failure. Perhaps using the auto-update-conda to update conda in advance in the miniconda action would help?

https://github.com/conda-incubator/setup-miniconda?tab=readme-ov-file#example-1-basic-usage

@gonuke
Copy link
Member Author

gonuke commented Dec 4, 2024

I'm working on the Win failures here: #966

@nuclearkevin nuclearkevin mentioned this pull request Dec 5, 2024
Open
@gonuke gonuke changed the base branch from develop to v3.2.4-rc1 December 12, 2024 16:52
@gonuke
Copy link
Member Author

gonuke commented Dec 12, 2024

I rebased this on v3.2.4-rc1 for inclusion in the pending release

@gonuke gonuke requested a review from pshriwise December 12, 2024 16:58
pshriwise
pshriwise approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Glad the Windows issues were resolved.

@pshriwise pshriwise merged commit f4ae921 into svalinn:v3.2.4-rc1 Dec 12, 2024
1 check passed
@gonuke
Copy link
Member Author

gonuke commented Dec 12, 2024

Looks good to me! Glad the Windows issues were resolved.

We decided to "pause" Windows CI, perhaps with plans to deprecate. It was only ever a priority to support the Cubit plugin, which is no longer a priority.

@pshriwise
Copy link
Member

Looks good to me! Glad the Windows issues were resolved.

We decided to "pause" Windows CI, perhaps with plans to deprecate. It was only ever a priority to support the Cubit plugin, which is no longer a priority.

Ah, thanks for clarifying! I wasn't following that closely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearkevin nuclearkevin nuclearkevin approved these changes

@pshriwise pshriwise pshriwise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git requires network access for all builds
3 participants
@gonuke @pshriwise @nuclearkevin