-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control Power and Source Strength #1001
base: devel
Are you sure you want to change the base?
Control Power and Source Strength #1001
Conversation
@gonuke @pshriwise
|
This may be related to scaling/DAGMC#968 that was driven by a request from @nuclearkevin |
Notably - CIVET doesn't have access to the outside world. So something more substantial must have changed than you think. |
It does look like some of the other actions failed for other reaons. I'll look into those too |
@lewisgross1296 The failures in Test, Test DAGMC, and Documentation are caused by an update to the CIVET test recipes that Cardinal uses (which removed pyne as a Cardinal dependency since we don't use the UWUW). As CIVET no longer initializes DAGMC's pyne submodule during the cloning phase, DAGMC attempts to clone it when building. This causes errors since the CIVET build boxes don't have internet access while compiling code, causing git failures when attempting to clone pyne. Once the change @gonuke made (which only clones pyne if UWUW is enabled with a compile flag) in svalinn/DAGMC#968 is merged, we'll update Cardinal's DAGMC submodule to fix these test failures. The other failures you're encountering are compiler errors. You're attempting to initialize a constant reference outside of the |
…ead of in constructor
I finally got this to compile, but wanted to ask for feedback. We are changing cardinal/src/base/OpenMCProblemBase.C Lines 110 to 134 in 17d18e0
So now these assignments need to be removed from the OpenMCProblemBase constructor and converted to list initialization. However they are conditioned on
Do others have opinions on setting the values to |
Job Documentation, step Sync to remote on ee04054 wanted to post the following: View the site here This comment will be updated on new commits. |
So it looks like despite compiling, there's still a larger issue. Apparently
At this point, I think this is a MOOSE design question. Tagging @loganharbour for input |
Yeah, this isn't how controllable parameters work. To control something, it needs to be a value. Not a name that points to something else. I might need to understand the goal a bit more. |
As of right now |
It's possible that we can achieve the same thing with a redesign -- I'm not married to postprocessors if there's a way to do this solely with controls. |
@lewisgross1296 A rather clunky workaround which will allow you to specify a controllable value of I haven't tried this myself so I can't guarantee it'll work, but it's worth a shot. |
Closes #1000 (woohoo 🎉 🎉1000 issues+PRs!!)