Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing macos 2022.4 plugin #144

Merged
merged 3 commits into from
Jan 19, 2023
Merged

fixing macos 2022.4 plugin #144

merged 3 commits into from
Jan 19, 2023

Conversation

bam241
Copy link
Member

@bam241 bam241 commented Dec 16, 2022

this should allow add the missing lib and to correct its @rpath in the plugin library

@bam241
Copy link
Member Author

bam241 commented Dec 16, 2022

this should fix #143 for 2022.4
cc @veeshy

once it is build you should be able to find a new version of the plugin in the build artifacts.
For your specific version here:
https://github.com/svalinn/Cubit-plugin/actions/runs/3712499162

@bam241
Copy link
Member Author

bam241 commented Dec 16, 2022

@veeshy the new build seems to be working for me

could you confirm ?

(Non-Commercial License) Cubit>help export dagmc

Help for words: export & dagmc.

export dagmc <filename> [faceting_tolerance <faceting tolerance>] [length_tolerance <length tolerance>]
     [normal_tolerance <normal tolerance>] [make_watertight] [verbose]
     [fatal_on_curves]


Help for words: export & dagmc.

export dagmc <filename> [faceting_tolerance <faceting tolerance>] [length_tolerance <length tolerance>]
     [normal_tolerance <normal tolerance>] [make_watertight] [verbose]
     [fatal_on_curves]

@veeshy
Copy link

veeshy commented Dec 16, 2022

Can confirm it works for me

@bam241
Copy link
Member Author

bam241 commented Dec 16, 2022

Great.

Could you take a look @gonuke ?

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bam241 - One small suggestion

scripts/unix_share_build.sh Outdated Show resolved Hide resolved
scripts/unix_share_build.sh Show resolved Hide resolved
@bam241
Copy link
Member Author

bam241 commented Jan 4, 2023

@gonuke, sorry it took me so long.

next time, if there is just a small suggestion like that, feel free to commit it, and merge it, so this doesn't have to wait for me and my limited availability....

@bam241
Copy link
Member Author

bam241 commented Jan 18, 2023

ping @gonuke ?

@gonuke
Copy link
Member

gonuke commented Jan 19, 2023

Thanks @bam241 - LGTM!

@gonuke gonuke merged commit 57eecf5 into svalinn:develop Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants