Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added become: true to neccessary tasks #31

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

mwester117
Copy link
Collaborator

As in #30 described, in an environment where the local user has no root privileges but the remote user has, the playbook will fail if executed with become: true globally.

This PR fixes this issue. It adds the become statement to neccessary remote tasks.

@mwester117 mwester117 self-assigned this Mar 29, 2024
@mwester117 mwester117 added the bug Something isn't working label Mar 29, 2024
@mwester117 mwester117 linked an issue Mar 29, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.14%. Comparing base (5af23e9) to head (884637c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   20.14%   20.14%           
=======================================
  Files           9        9           
  Lines        1092     1092           
  Branches      212      212           
=======================================
  Hits          220      220           
  Misses        872      872           
Flag Coverage Δ
sanity 20.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwester117
Copy link
Collaborator Author

mwester117 commented Mar 29, 2024

@quentin-rey can you please checkout this feature branch and verify the changes are working on RHEL?
My tests were sucessfull.

@mwester117 mwester117 requested a review from nwerker March 29, 2024 00:45
@mwester117 mwester117 marked this pull request as ready for review March 29, 2024 00:45
@quentin-rey
Copy link
Contributor

I can confirm that the changes you've made fix the problem! Thanks for your quick fixes!
Tested on RHEL 8.9.

@nwerker nwerker merged commit 66f0923 into main Apr 8, 2024
22 checks passed
@mwester117 mwester117 deleted the feature_fix_become branch May 27, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Rights issues for rpm installation on Redhat Linux
4 participants