Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add urlencode filter to potentially affected variables #29

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add urlencode filter to potentially affected variables #29

merged 1 commit into from
Mar 28, 2024

Conversation

quentin-rey
Copy link
Contributor

Description

Add urlencode filter to variables used in API URLs

Motivation

Avoid errors when variables contain spaces

Additional details

N/A

Related issues and pull requests

@mwester117 mwester117 self-requested a review March 28, 2024 18:12
@mwester117 mwester117 added the bug Something isn't working label Mar 28, 2024
@mwester117 mwester117 self-assigned this Mar 28, 2024
mwester117
mwester117 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@mwester117 mwester117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have successfully tested your changes with a site and group that contain spaces.

@mwester117 mwester117 merged commit 5af23e9 into svalabs:main Mar 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwester117 mwester117 mwester117 approved these changes

Assignees

@mwester117 mwester117

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug: 'dict object' has no attribute 'json' error resulting from the presence of a space in the site name
2 participants
@quentin-rey @mwester117