This repository has been archived by the owner on Oct 26, 2022. It is now read-only.
feat: lock on first deposit #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boringcrypto
reviewed
Jan 5, 2022
| @@ -185,8 +185,6 @@ contract BentoBox is MasterContractManager, BoringBatchable { | |||
| IERC20 token = token_ == USE_ETHEREUM ? wethToken : token_; | |||
| Rebase memory total = totals[token]; | |||
|
|
|||
| // If a new token gets added, the tokenSupply call checks that this is a deployed contract. Needed for security. | |||
| require(total.elastic != 0 || token.totalSupply() > 0, "BentoBox: No tokens"); | |||
There was a problem hiding this comment.
This check protects against adding shares for a token that is yet to be deployed (predictable address with CREATE2)
boringcrypto
reviewed
Jan 5, 2022
| total.base = total.base.add(share.to128()); | ||
| if (total.elastic == 0) { | ||
| // Upon the first deposit permanently lock the MINIMUM_SHARE_BALANCE amount of tokens | ||
| share = share.sub(MINIMUM_SHARE_BALANCE); |
There was a problem hiding this comment.
YieldBox has a different solution for this that doesn't burn any user tokens, but adds a virtual balance instead. Would love your review of this new method :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.