fixed 38221: When switching from custom to reused title in the settin…

…gs of ContainerReferences, the title is not immediately updated
surlabs · Oct 23, 2023 · 77aa8b6 · 77aa8b6
1 parent c6c15b4
commit 77aa8b6
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/Services/ContainerReference/classes/class.ilContainerReferenceGUI.php b/Services/ContainerReference/classes/class.ilContainerReferenceGUI.php
@@ -292,11 +292,6 @@ protected function loadPropertiesFromSettingsForm(ilPropertyFormGUI $form): bool
         $ok = true;
         $access = $DIC->access();
 
-        $this->object->setTitleType((int) $form->getInput('title_type'));
-        if ((int) $form->getInput('title_type') === ilContainerReference::TITLE_TYPE_CUSTOM) {
-            $this->object->setTitle($form->getInput('title'));
-        }
-
         // check access
         if (
             !$access->checkAccess('visible', '', (int) $form->getInput('target_id'))
@@ -318,6 +313,14 @@ protected function loadPropertiesFromSettingsForm(ilPropertyFormGUI $form): bool
             ilObject::_lookupObjId((int) $form->getInput('target_id'))
         );
 
+        // set title after target id, so that the title can be reused immediately
+        $this->object->setTitleType((int) $form->getInput('title_type'));
+        if ((int) $form->getInput('title_type') === ilContainerReference::TITLE_TYPE_CUSTOM) {
+            $this->object->setTitle($form->getInput('title'));
+        } elseif ((int) $form->getInput('title_type') === ilContainerReference::TITLE_TYPE_REUSE) {
+            $this->object->setTitle(ilObject::_lookupTitle($this->object->getTargetId()));
+        }
+
         return $ok;
     }