Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle the scenario where strategies are empty #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

handle the scenario where strategies are empty #82

wants to merge 1 commit into from

Conversation

khoadng
Copy link

@khoadng khoadng commented Mar 13, 2024 •
edited
Loading

Checklist

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Is there an existing issue for this PR?
  • Have the files been linted and formatted?
  • Have the docs been updated to match the changes in the PR?
  • Have the tests been updated to match the changes in the PR?
  • Attached videos/screenshots demonstrating the fix/feature.
  • Have you run the tests locally to confirm they pass?

Changes

Return early if there are no strategies at all.

How does this PR fix the problem?

Return early if there are no strategies.

@mhmdVoj
Copy link

mhmdVoj commented Apr 3, 2024

I hope you are fine.
What does it mean that the package does not execute startListenUserConsent when there is no Android platform and throws an error? Does this mean that these parts are not needed in iOS? So this package does not work for ios?

@DmitrDomrachev DmitrDomrachev requested review from ekinsdrow and removed request for ekinsdrow April 7, 2024 13:40
@plasticfiresam plasticfiresam added the P1 Priority 1 Issue likely blocking user now. label May 13, 2024
@plasticfiresam plasticfiresam self-assigned this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sadhorsephile Sadhorsephile Sadhorsephile approved these changes

Assignees

@plasticfiresam plasticfiresam

Labels
P1 Priority 1 Issue likely blocking user now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Unhandled Exception on iOS if no additional strategies are provided
4 participants
@khoadng @mhmdVoj @Sadhorsephile @plasticfiresam