Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/frontend] Add login button to index page which reiterates info about clients #3377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vivlim
Copy link

@vivlim vivlim commented Sep 30, 2024

Description

This PR adds a 'Log in' button to the index page. When clicked, a page will be shown which contains

  • A link to access /settings
  • The list of client applications that is also present on the index

The goal is to provide an easier way to discover how to log on / access the settings without having to read and understand all of the text on the index first. I was talking with someone recently who had set up an account but wasn't sure what to do next; they had skimmed the index page but their eyes glossed over the part where there was a list of software with different logos. I think reiterating just that information when a user is trying to log in is an improvement.

I also think it's nice to have a way to get to settings that doesn't require typing /settings in the address bar.

This change is live at https://electron.phosphor.buzz if you want to try it out. I tried to make it look OK at different widths and think it turned out alright.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst tsmethurst changed the title Add login button to index page which reiterates info about clients [feature/frontend] Add login button to index page which reiterates info about clients Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant