This repository has been archived by the owner on Mar 5, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 93
Korean locale files #180
Open
akamotaco
wants to merge
37
commits into
superpowers:master
Choose a base branch
from
akamotaco:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Korean locale files #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyxap
suggested changes
Sep 29, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add empty line for each file, thanks
"tileSetProperty": "타일셋 속성", | ||
"layers": "레이어" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to add new line to the of the file (blank)
"label": "큐빅 모델 출력기", | ||
"cubicModel": "큐빅 모델" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here ^
"stretch": "늘이기" | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And for each file
add empty new line.
add empty new line
add new empty line
add new empty line
add new empty line
add empty new line
add new empty line
add new empty line
add new empty line
add new empty line
add empty new line
add empty new line
add empty new line
new empty line added.
empty new line added.
empty new line added.
empty new line added.
empty new line added.
empty new line added.
empty new line added.
empty new line added.
empty new line added.
Empty new line added.
Empty new line added.
Empty new line added.
Empty new line added.
Empty new line added.
Empty new line added.
Empty new line added.
Empty new line added.
Empty new line added.
Empty new line added.
Empty new line added.
Empty new line added.
Empty new line added.
Empty new line added.
p{margin-top:0;margin-bottom:0}
I added empty new line in the files using github editor and push new pushed 'New pull request'.Please check these.Thanks.
--------- 원본 메일 ---------
보낸사람: Roman Kukharuk <[email protected]>
받는사람: superpowers/superpowers-game <[email protected]>
참조: akamotaco <[email protected]>, Author <[email protected]>
날짜: 17.09.29 14:53 GMT +0900
제목: Re: [superpowers/superpowers-game] Korean locale files (#180)
@kyxap requested changes on this pull request.
Please add empty line for each file, thanks
In plugins/default/arcadePhysics2D/public/locales/ko/componentEditors.json:
+ "type": "형태",
+ "typeOptions": {
+ "box": "사각형",
+ "tileMap": "타일맵"
+ },
+
+ "movable": "이동 가능",
+ "size": "크기",
+ "offset": "오프셋",
+ "bounce": "바운스",
+
+ "tileMap": "타일맵",
+ "tileSetProperty": "타일셋 속성",
+ "layers": "레이어"
+ }
+}
You forgot to add new line to the of the file (blank)
In plugins/default/cubicModel/public/locales/ko/componentEditors.json:
@@ -0,0 +1,6 @@
+{
+ "CubicModelRenderer": {
+ "label": "큐빅 모델 출력기",
+ "cubicModel": "큐빅 모델"
+ }
+}
Same here ^
In plugins/default/cubicModel/public/locales/ko/cubicModelEditor.json:
+ "show": "보이기"
+ },
+ "inspector": {
+ "position": "위치",
+ "orientation": "방향",
+ "shape": "쉐입",
+ "shapeType": "형태",
+ "shapeOptions": {
+ "box": "상자"
+ },
+ "offset": "오프셋",
+ "size": "크기",
+ "stretch": "늘이기"
+ }
+ }
+}
And for each file
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
These file is Korean script file for Superpowers-core.
I hope it will be help to korean developers.
Thanks.