This repository has been archived by the owner on Mar 5, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 93
Precompile scripts #179
Open
bilou84
wants to merge
8
commits into
master
Choose a base branch
from
precompile-scripts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Precompile scripts #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time (client build not working yet)
…veral pieces and is central to the system
kyxap
suggested changes
Sep 29, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small code style upd requested ;)
}, | ||
"devDependencies": { | ||
"@types/convert-source-map": "0.0.30", | ||
"@types/uglify-js": "^2.6.28" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty line at the end off the file is missed.
return tsResult.js.pipe(gulp.dest("./")); | ||
}); | ||
|
||
// All |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// All
Is not clear comment :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves exports of games in a couples ways:
After testing it on a couple games, I average about 5MB less on the build size which is quite good!
I didn't run the numbers myself on the loading times, but spencer gave it a try and the results are quite nice as well! https://twitter.com/StuffBySpencer/status/815027274319859712
There is one downside though. We are breaking the compatibility with third party plugins.
There is two small things to change when exposing some scripts API (which is the most common thing plugins do of course...):
It would be nice if we could get in touch with developpers to update their plugins before we release the next version. Since it's very easy to fix, hopefully we can get everyeone!