-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query params to /super-tokens page for filter + pagination #99
base: master
Are you sure you want to change the base?
Add query params to /super-tokens page for filter + pagination #99
Conversation
…ere/superfluid-console into add-query-params-to-url
@thevolcanomanishere is attempting to deploy a commit to the Superfluid Finance Team on Vercel. A member of the Team first needs to authorize it. |
Appreciate the contribution! The advantage of serializing into the URL is that it's a general solution we could use for all the tables across Console with hopefully minimal code (and maintenance) per table. As for the cosmetics of the URL, the serialization process could be extended later to make it comma-separated or something else visually pleasing for the URL, i.e. the serialization doesn't have to be JSON. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@kasparkallas Implemented serialisation and some small fixes. |
Thanks for your effort! I appreciate it and sorry for the slow response. Looks pretty good but some feedback:
The 2. and 3. are not critical and are more related to perfect code structure than feature correctness. I can also tackle these myself at some point. |
@kasparkallas This PR includes logic for handling pagination which the previous PR lacked.
I chose not to serialise the filter purely because the URL looks nicer compared to a stringified object in the address bar. There is also some logic in
setUrlQueryParam()
for handling 1 letter filters.