[ETHEREUM-CONTRACTS] payable macro forwarder #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
d10r
commented
Oct 1, 2024
hellwolf
reviewed
Oct 1, 2024
hellwolf
reviewed
Oct 1, 2024
packages/ethereum-contracts/contracts/interfaces/utils/IUserDefinedMacro.sol
Show resolved
Hide resolved
d10r
requested review from
ngmachado,
kasparkallas and
vmichalik
as code owners
hellwolf
approved these changes
Oct 3, 2024
8 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2025 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 111 111
Lines 7001 7003 +2
Branches 964 963 -1
=======================================
+ Hits 6187 6189 +2
Misses 812 812
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
XKCD Comic RelifLink: https://xkcd.com/2025 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since batch calls are payable, making the MacroForwarder payable allows the building of macros forwarding ETH.
This PR includes a test case with a new example macro offering more than one operation (create/update/delete flow), using the convention of paramsX view functions for convenient parameter encoding.