Workflow: tweak test-local-subgraph #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2013 +/- ##
=======================================
Coverage 88.45% 88.45%
=======================================
Files 111 111
Lines 6971 6971
Branches 933 934 +1
=======================================
Hits 6166 6166
Misses 803 803
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kasparkallas
approved these changes
Aug 29, 2024
XKCD Comic RelifLink: https://xkcd.com/2013 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
At some point, the sdk-core/subgraph test cases started to fail with "socket hang up" error when querying subgraph.
After some research, it was discovered that it is due to the usage of an older version of the "cross-fetch" polyfill which didn't support node 20+, see here and here.
Solution
The newer cross-fetch project solved this. The solution is to fix the "resolution" of the cross-fetch in this project to the latest, for now.
Additionally, this PR also:
a) include some minor refactoring around the test setup process,
b) test against both node 18 and 20 for SDK core, and test against node 20 for subgraph.