Update dependencies #2011

hellwolf · 2024-08-27T09:04:34Z

Dependency updates:
- update all dependencies, targeting minor versions
- update major versions of:
  - hardhat 9
  - syncpack
  - solhint
  - webpack-cli 5
  - prettier-eslint, @typescript-eslint/eslint-plugin, @typescript-eslint/parser
  - @nomicfoundation/hardhat-ethers
  - node-jq
  - chai-as-promised
  - nyc
  - @graphql-codegen/near-operation-file-preset
syncpack linting:
- integrated into ci and pre-commit
- format all package.json
- pin stack-trace package version due to its es module usage
removed dependency resolutions:
- root: mocha
- sdk-core: graphql
upgrade nodejs usage
- making node22 default
- testing matrix expanded to 18,20,22
update to yarn 1.22.22

Dependencies left not updated to new major versions

github-actions · 2024-08-27T09:04:56Z

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

CHANGELOG.md modified
Double check before merge

This reverts commit 3bfc61b.

- prettier-eslint, @typescript-eslint/eslint-plugin, @typescript-eslint/parser - @nomicfoundation/hardhat-chai-matchers - @nomicfoundation/hardhat-ethers - node-jq - chai-as-promised

codecov · 2024-08-27T16:40:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (3d5df70) to head (ff9ed76).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #2011      +/-   ##
==========================================
- Coverage   88.45%   88.36%   -0.09%     
==========================================
  Files         111      111              
  Lines        6971     6999      +28     
  Branches      933      962      +29     
==========================================
+ Hits         6166     6185      +19     
- Misses        803      812       +9     
  Partials        2        2

Flag	Coverage Δ
ethereum-contracts	`94.51% <ø> (ø)`
sdk-core	`88.36% <ø> (-0.09%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This reverts commit 67ed1e7.

hellwolf · 2024-08-29T07:44:42Z

.husky/pre-commit

@@ -2,6 +2,7 @@
 . "$(dirname "$0")/_/husky.sh"

 # always lint these
+npm run lint:syncpack


might be assuming too much: if you don't use nix, you need to have shellcheck and actionlint installed globally.

shellcheck can be installed from NPM and could be added as a dev dependency to the project. Doesn't seem to be the case for actionlint.

let me clean up a bit of the shell scripts that have these dependencies.

Cleaned up with some warning messages.

kasparkallas · 2024-08-29T08:07:27Z

.husky/pre-commit

@@ -2,6 +2,7 @@
 . "$(dirname "$0")/_/husky.sh"

 # always lint these
+npm run lint:syncpack


shellcheck can be installed from NPM and could be added as a dev dependency to the project. Doesn't seem to be the case for actionlint.

kasparkallas · 2024-08-29T08:08:34Z

package.json

+        "@types/lodash": "^4.17.7",
+        "@types/mocha": "^10.0.7",
+        "@typescript-eslint/eslint-plugin": "8.3.0",
+        "@typescript-eslint/parser": "8.3.0",


Not sure if some of these locked versions are on purpose

probably not, not sure why it happenned with syncpack updating them

Codified the rules with the syncpack:

semverGroups: # Note: rule priority is top (high) to bottom (low) - label: Use looser ranges for metadata and ethereum-contracts local packages dependencies: - "@superfluid-finance/metadata" - "@superfluid-finance/ethereum-contracts" range: "^" - label: Use exact version for prod dependencies dependencyTypes: ["prod"] range: "" - label: Use looser range by default range: "^"

d10r · 2024-08-29T13:38:10Z

getting this when committing in ethereum-contracts:

husky - DEPRECATED

Please remove the following two lines from .husky/pre-commit:

#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

They WILL FAIL in v10.0.0

d10r · 2024-08-29T13:41:36Z

new behaviour:

Versions
= Pin stack-trace to the same version, since newer version starts to use ES module 
     1 ✓ already valid
= Default Version Group ========================================================
✘ @superfluid-finance/metadata ^1.4.1 → ^1.5.0 packages/ethereum-contracts/package.json > devDependencies [LocalPackageMismatch]
✘ @superfluid-finance/metadata ^1.4.1 → ^1.5.0 packages/js-sdk/package.json > dependencies [LocalPackageMismatch]
✘ @superfluid-finance/metadata ^1.4.1 → ^1.5.0 packages/sdk-core/package.json > dependencies [LocalPackageMismatch]
✘ @superfluid-finance/metadata ^1.4.1 → ^1.5.0 packages/subgraph/package.json > devDependencies [LocalPackageMismatch]
✘ @superfluid-finance/metadata ^1.4.1 → ^1.5.0 packages/automation-contracts/scheduler/package.json > devDependencies [LocalPackageMismatch]
✘ @superfluid-finance/metadata ^1.4.1 → ^1.5.0 packages/automation-contracts/autowrap/package.json > devDependencies [LocalPackageMismatch]
   117 ✓ already valid
     6 ✓ can be auto-fixed
Semver Ranges
= the version property of package.json files must always be exact ==============
✓ 11 valid
= Use looser ranges for metadata and ethereum-contracts local packages =========
✓ 11 valid
= Use exact version for prod dependencies ======================================
✓ 23 valid
= Use looser range by default ==================================================
✓ 79 valid
husky - pre-commit script failed (code 1)

I used yarn manage-versions to fix, which had this side effect:

+++ b/packages/subgraph/package.json
@@ -5,11 +5,11 @@
     "dependencies": {
         "@graphprotocol/graph-cli": "0.80.1",
         "@graphprotocol/graph-ts": "0.35.1",
-        "@superfluid-finance/sdk-core": "0.8.0",
+        "@superfluid-finance/sdk-core": "^0.8.0",

probably not intended (?)

hellwolf · 2024-08-30T07:42:42Z

getting this when committing in ethereum-contracts:

husky - DEPRECATED

Please remove the following two lines from .husky/pre-commit:

#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

They WILL FAIL in v10.0.0

fixed

hellwolf · 2024-08-30T08:00:02Z

new behaviour:

Versions
= Pin stack-trace to the same version, since newer version starts to use ES module 
     1 ✓ already valid
= Default Version Group ========================================================
✘ @superfluid-finance/metadata ^1.4.1 → ^1.5.0 packages/ethereum-contracts/package.json > devDependencies [LocalPackageMismatch]
✘ @superfluid-finance/metadata ^1.4.1 → ^1.5.0 packages/js-sdk/package.json > dependencies [LocalPackageMismatch]
✘ @superfluid-finance/metadata ^1.4.1 → ^1.5.0 packages/sdk-core/package.json > dependencies [LocalPackageMismatch]
✘ @superfluid-finance/metadata ^1.4.1 → ^1.5.0 packages/subgraph/package.json > devDependencies [LocalPackageMismatch]
✘ @superfluid-finance/metadata ^1.4.1 → ^1.5.0 packages/automation-contracts/scheduler/package.json > devDependencies [LocalPackageMismatch]
✘ @superfluid-finance/metadata ^1.4.1 → ^1.5.0 packages/automation-contracts/autowrap/package.json > devDependencies [LocalPackageMismatch]
   117 ✓ already valid
     6 ✓ can be auto-fixed
Semver Ranges
= the version property of package.json files must always be exact ==============
✓ 11 valid
= Use looser ranges for metadata and ethereum-contracts local packages =========
✓ 11 valid
= Use exact version for prod dependencies ======================================
✓ 23 valid
= Use looser range by default ==================================================
✓ 79 valid
husky - pre-commit script failed (code 1)

I used yarn manage-versions to fix, which had this side effect:

+++ b/packages/subgraph/package.json
@@ -5,11 +5,11 @@
     "dependencies": {
         "@graphprotocol/graph-cli": "0.80.1",
         "@graphprotocol/graph-ts": "0.35.1",
-        "@superfluid-finance/sdk-core": "0.8.0",
+        "@superfluid-finance/sdk-core": "^0.8.0",

probably not intended (?)

Our rules for semvers of packages is coded in .syncpackrc.yml, this currently requires 'exact' version for prod packages except metadata and ethereum-contracts:

semverGroups:
  # Note: rule priority is top (high) to bottom (low)
  - label: Use looser ranges for metadata and ethereum-contracts local packages
    dependencies:
      - "@superfluid-finance/metadata"
      - "@superfluid-finance/ethereum-contracts"
    range: "^"
  - label: Use exact version for prod dependencies
    dependencyTypes: ["prod"]
    range: ""
  - label: Use looser range by default
    range: "^"

Lerna has a option --exact when managing versions.

But I'd like to review the semverGroups rule before closing the PR, since I find the exceptions "fishy".

…up rule

github-actions · 2024-08-30T08:42:14Z

XKCD Comic Relif

Link: https://xkcd.com/2011

update all dependencies, targeting patch+minor

f6e7671

hellwolf added 17 commits August 27, 2024 12:21

root package.json: latest major syncpack

41162ce

syncpack format all package.json

3bfc61b

added .syncpackrc

23fe126

syncpack lint: graphql-request HighestSemverMismatch

365fe0d

added lint:syncpack to ci and pre-commit

938eb6c

Revert "syncpack format all package.json"

5ffe6cc

This reverts commit 3bfc61b.

to .syncpackrc.yml

25aa3a0

syncpack: format package.json files

c5dacaf

syncpack: format package.json files

0a4f9d6

workflow: fix stack-trace bug

30d2861

dependency: update solhint

d5c50ac

dependency: update husky to 9.1.5

ef4ce30

dependency: update a few small fishes

32f38e6

- prettier-eslint, @typescript-eslint/eslint-plugin, @typescript-eslint/parser - @nomicfoundation/hardhat-chai-matchers - @nomicfoundation/hardhat-ethers - node-jq - chai-as-promised

downgrade @nomicfoundation/hardhat-chai-matchers

4f707f4

dependency: update lerna

8a96cb5

dependency: hardhat 9

ca0358c

dependency: update to webpack-cli 5

9e75ebf

hellwolf added 4 commits August 27, 2024 22:27

dependency: update nyc

2be5a2f

dependency: update @graphql-codegen/near-operation-file-preset

0e0fb10

workflow: try node20 in call.test-local-subgraph.yml

5db2d1e

flake: adding nodejs_22

5febc6e

hellwolf changed the title ~~Update all dependencies, targeting patch+minor~~ Update dependencies Aug 27, 2024

hellwolf added 5 commits August 27, 2024 23:54

fix subgraph workflows

9bc3013

fix subgraph helpers.ts

86a3a79

fix subgraph workflow docker-compose

8269674

dependency: try to update graphql-request

67ed1e7

Revert "dependency: try to update graphql-request"

8c25833

This reverts commit 67ed1e7.

hellwolf added 7 commits August 28, 2024 23:11

dependency: remove resolutions.mocha

db9f07f

depencency: remove resolution.graphql

79e9fb0

workflow: make node22 default and testing 18,20,22

f7dfa9e

workflow: make node22 default and testing 18,20,22

b40312f

Merge branch 'dev' into update-deps-20240822

24a4428

update to yarn 1.22.22

62f0ef2

add .yarnrc to build input files

95c0068

hellwolf marked this pull request as ready for review August 29, 2024 07:42

hellwolf requested review from kasparkallas, d10r, ngmachado, vmichalik and a team as code owners August 29, 2024 07:42

hellwolf commented Aug 29, 2024

View reviewed changes

kasparkallas approved these changes Aug 29, 2024

View reviewed changes

hellwolf added 4 commits August 29, 2024 13:18

workflow cleanups

d8f003d

pre-commit script cleanup

fffe5d7

syncpack fix mismatches in semvers

690475a

update yarn.lock

bafb888

fix .husky/pre-commit

8e89c69

d10r approved these changes Aug 30, 2024

View reviewed changes

hellwolf added 2 commits August 30, 2024 11:15

remove @superfluid-finance/ethereum-contracts from special semver gro…

445c143

…up rule

update readme

ff9ed76

hellwolf merged commit 9a4abaf into dev Aug 30, 2024
23 of 24 checks passed

hellwolf deleted the update-deps-20240822 branch August 30, 2024 08:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependencies #2011

Update dependencies #2011

hellwolf commented Aug 27, 2024 •

edited

Loading

github-actions bot commented Aug 27, 2024

codecov bot commented Aug 27, 2024 •

edited

Loading

hellwolf Aug 29, 2024

kasparkallas Aug 29, 2024

hellwolf Aug 29, 2024

hellwolf Aug 29, 2024

kasparkallas Aug 29, 2024

kasparkallas Aug 29, 2024

hellwolf Aug 29, 2024

hellwolf Aug 29, 2024

d10r commented Aug 29, 2024 •

edited

Loading

d10r commented Aug 29, 2024

hellwolf commented Aug 30, 2024

hellwolf commented Aug 30, 2024

github-actions bot commented Aug 30, 2024

Update dependencies #2011

Update dependencies #2011

Conversation

hellwolf commented Aug 27, 2024 • edited Loading

github-actions bot commented Aug 27, 2024

Changelog Reminder

codecov bot commented Aug 27, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

d10r commented Aug 29, 2024 • edited Loading

d10r commented Aug 29, 2024

hellwolf commented Aug 30, 2024

hellwolf commented Aug 30, 2024

github-actions bot commented Aug 30, 2024

XKCD Comic Relif

hellwolf commented Aug 27, 2024 •

edited

Loading

codecov bot commented Aug 27, 2024 •

edited

Loading

d10r commented Aug 29, 2024 •

edited

Loading