[ETHEREUM-CONTRACTS] add missing batch call operations #1967
Conversation
d10r
changed the title
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
packages/ethereum-contracts/contracts/superfluid/Superfluid.sol
Outdated
Show resolved
Hide resolved
packages/ethereum-contracts/contracts/superfluid/Superfluid.sol
Outdated
Show resolved
Hide resolved
packages/ethereum-contracts/contracts/superfluid/Superfluid.sol
Outdated
Show resolved
Hide resolved
|
@d10r Is the main idea to delegate non-SuperApp and non-Superfluid batch operations through the new DMZForwarder contract? |
packages/ethereum-contracts/contracts/utils/SuperfluidFrameworkDeploymentSteps.sol
Show resolved
Hide resolved
| returns(bool success, bytes memory returnData) | ||
| { | ||
| // solhint-disable-next-line avoid-low-level-calls | ||
| (success, returnData) = target.call{value: msg.value}(data); |
There was a problem hiding this comment.
Is there any merit to using address(this).balance here or trying to return the leftover? (Probably not.)
There was a problem hiding this comment.
Is there any merit to using address(this).balance here
I don't think so
trying to return the leftover
No, but I added a function for withdrawing stuck native tokens.
packages/ethereum-contracts/contracts/superfluid/Superfluid.sol
Outdated
Show resolved
Hide resolved
| @@ -882,6 +882,20 @@ contract SuperToken is | |||
| _downgrade(msg.sender, account, account, amount, "", ""); | |||
| } | |||
|
|
|||
| function operationUpgradeTo(address account, address to, uint256 amount) | |||
There was a problem hiding this comment.
this will require Token upgrades
There was a problem hiding this comment.
right. Also we may later consider deprecating the variants without to argument.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1967 +/- ##
==========================================
- Coverage 88.60% 88.53% -0.07%
==========================================
Files 118 119 +1
Lines 7361 7388 +27
Branches 967 975 +8
==========================================
+ Hits 6522 6541 +19
- Misses 837 845 +8
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| * @dev DMZForwarder.forward2771Call batch operation type | ||
| * | ||
| * Call spec: | ||
| * forward2771Call( |
There was a problem hiding this comment.
to be in sync with the rest, use typed signature, and call "data" "callData" to be more specific.
XKCD Comic RelifLink: https://xkcd.com/1967 |
Adds missing batch call operations, see #1895