Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[METADATA] remove hosted endpoint for scroll-mainnet #1914

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

d10r
Copy link
Collaborator

@d10r d10r commented Mar 26, 2024

Was supposed to be part of #1889 , but apparently I didn't push the commit

Copy link

github-actions bot commented Mar 26, 2024

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@hellwolf hellwolf enabled auto-merge March 26, 2024 14:44
@hellwolf hellwolf added this pull request to the merge queue Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.07%. Comparing base (d58178f) to head (adf0a07).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1914   +/-   ##
=======================================
  Coverage   89.07%   89.07%           
=======================================
  Files         113      113           
  Lines        5939     5939           
  Branches      216      216           
=======================================
  Hits         5290     5290           
  Misses        597      597           
  Partials       52       52           
Flag Coverage Δ
ethereum-contracts 96.97% <ø> (ø)
sdk-core 81.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into dev with commit 91d9381 Mar 26, 2024
20 checks passed
@hellwolf hellwolf deleted the remove-scroll-hosted-endpoint branch March 26, 2024 16:33
Copy link

XKCD Comic Relif

Link: https://xkcd.com/1914
https://xkcd.com/1914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants