Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-core] add getTotalAmountReceivedByPoolMember #1902

Conversation

kasparkallas
Copy link
Contributor

@kasparkallas kasparkallas commented Mar 20, 2024

What?
New contract function to expose. Only available on testnets currently.

Copy link

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@kasparkallas kasparkallas marked this pull request as draft March 20, 2024 13:20
@kasparkallas kasparkallas changed the base branch from 2024-03-subgraph-gda-feature-branch to sdk-core-and-redux-add-gda-pool-subgraph-entity-queries March 20, 2024 13:22
@kasparkallas kasparkallas changed the base branch from sdk-core-and-redux-add-gda-pool-subgraph-entity-queries to dev March 20, 2024 13:59
@kasparkallas kasparkallas changed the base branch from dev to sdk-core-and-redux-add-gda-pool-subgraph-entity-queries March 20, 2024 13:59
@kasparkallas kasparkallas changed the title [wip][sdk-core] add getTotalAmountReceivedByPoolMember [sdk-core] add getTotalAmountReceivedByPoolMember Mar 20, 2024
@0xdavinchee 0xdavinchee marked this pull request as ready for review March 20, 2024 14:10
Copy link
Contributor

@0xdavinchee 0xdavinchee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xdavinchee 0xdavinchee merged commit cc9cb43 into sdk-core-and-redux-add-gda-pool-subgraph-entity-queries Mar 20, 2024
17 checks passed
@0xdavinchee 0xdavinchee deleted the sdk-core-gettotalamountreceivedbypoolmember branch March 20, 2024 14:22
Copy link

XKCD Comic Relif

Link: https://xkcd.com/1902
https://xkcd.com/1902

github-merge-queue bot pushed a commit that referenced this pull request Mar 26, 2024
* add gda pool subgraph entity queries

* improve infinity paging api

* add some robustness to transaction serialization

* reduce tx tracking timeout from 10 mins to 3 mins

* remove unnecessary toLowerCase

* changeset

* [SUBGRAPH] [BUG] PoolMember not getting updated when the member units change (#1877)

* add a test starter

* add the test

* fixes

* improve test

* update dev container for matchstick compatibility

* implement the fix

* clean-up

* add elaborate test for pool  total amount received

* fix test issue

* add even more comments

* fix test name

* ignore test

---------

Co-authored-by: 0xdavinchee <[email protected]>

* [SUBGRAPH] approval mapping (#1878)

* approval mapping

* missing addresses

* missing addresses cont.

* no-op, trigger build

* fix tests

---------

Co-authored-by: Kaspar Kallas <[email protected]>

* [subgraph] Fix Correctness of GDA Entities (#1890)



---------

Co-authored-by: 0xdavinchee <[email protected]>

* add getTotalAmountReceivedByPoolMember to sdk-core (#1902)

* update entities based on new subgraph

* map name, isnfttransfer, isnftapproval

* fix merge issue

* remove unnecessary files

* update gitignore

---------

Co-authored-by: 0xdavinchee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants