[SUBGRAPH] approval mapping #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparkallas
reviewed
Mar 6, 2024
|
We use the same event entity for the ERC-20 Approval and the NFT Approval? Why not use another entity? |
we can, no strong reason to use the same for both |
we decided to re-use the event |
kasparkallas
approved these changes
Mar 11, 2024
|
test is broken |
ah, it's the test that's currently supposed to fail, will ignore 
|
So we shall wait for the fix, from some future PR. Right? |
kasparkallas
changed the base branch from
subgraph-poolmember-bug
to
2024-03-subgraph-gda-feature-branch
future PR, we're already working it created a feature branch ( |
…nch' into 1834-approval-event-mapping
kasparkallas
merged commit a58cf6b
into
2024-03-subgraph-gda-feature-branch
14 checks passed
XKCD Comic RelifLink: https://xkcd.com/1878 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
* [SUBGRAPH] [BUG] PoolMember not getting updated when the member units change (#1877) * add a test starter * add the test * fixes * improve test * update dev container for matchstick compatibility * implement the fix * clean-up * add elaborate test for pool total amount received * fix test issue * add even more comments * fix test name * ignore test --------- Co-authored-by: 0xdavinchee <[email protected]> * [SUBGRAPH] approval mapping (#1878) * approval mapping * missing addresses * missing addresses cont. * no-op, trigger build * fix tests --------- Co-authored-by: Kaspar Kallas <[email protected]> * [subgraph] Fix Correctness of GDA Entities (#1890) --------- Co-authored-by: 0xdavinchee <[email protected]> * add createdAtTimestamp/BlockNumber for ATS entity (#1909) * [SUBGRAPH] fix governance config always null (#1908) * fix governance config always null * fix broken tests * [SUBGRAPH] fix resolver entry (#1843) * fix resolver entry * do resolver rpc call on token initialization and remove handleTokenRPCCalls in subsequent token calls * fix broken tests * TODO comment can be removed * remove mistakenly added files --------- Co-authored-by: 0xdavinchee <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
* add gda pool subgraph entity queries * improve infinity paging api * add some robustness to transaction serialization * reduce tx tracking timeout from 10 mins to 3 mins * remove unnecessary toLowerCase * changeset * [SUBGRAPH] [BUG] PoolMember not getting updated when the member units change (#1877) * add a test starter * add the test * fixes * improve test * update dev container for matchstick compatibility * implement the fix * clean-up * add elaborate test for pool total amount received * fix test issue * add even more comments * fix test name * ignore test --------- Co-authored-by: 0xdavinchee <[email protected]> * [SUBGRAPH] approval mapping (#1878) * approval mapping * missing addresses * missing addresses cont. * no-op, trigger build * fix tests --------- Co-authored-by: Kaspar Kallas <[email protected]> * [subgraph] Fix Correctness of GDA Entities (#1890) --------- Co-authored-by: 0xdavinchee <[email protected]> * add getTotalAmountReceivedByPoolMember to sdk-core (#1902) * update entities based on new subgraph * map name, isnfttransfer, isnftapproval * fix merge issue * remove unnecessary files * update gitignore --------- Co-authored-by: 0xdavinchee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApprovalEventwhenApprovalevent is emitted from a SuperToken contract.closes #1834