[SUBGRAPH] fix resolver entry #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparkallas
approved these changes
Mar 8, 2024
| if (isListed) { | ||
| resolverEntry.isToken = Token.load(target.toHex()) != null; | ||
| } | ||
| resolverEntry.updatedAtBlockNumber = block.number; |
There was a problem hiding this comment.
is it ok to always update when getOrInit is called? it's called in very few places?
hellwolf
changed the title
kasparkallas
changed the base branch from
dev
to
2024-03-subgraph-gda-feature-branch
|
how is this one doing |
|
the fix did not work, will be investigated. |
hellwolf
changed the base branch from
2024-03-subgraph-gda-feature-branch
to
dev
|
@elvijsTDL please write a concrete bug report on the issue related to this. |
hellwolf
changed the title
|
The subgraph shows some of the tokens as unlisted even if they should be e.g. ETHx , fUSDCx If you query the listed tokens you can see that they are missing:
At some point it has flipped from listed to unlisted as it used to work fine This might be related to GoodDollar G$ getting unlisted from Celo too |
…CCalls in subsequent token calls
kasparkallas
changed the base branch from
dev
to
2024-03-subgraph-gda-feature-branch
0xdavinchee
merged commit 6a9e78b
into
2024-03-subgraph-gda-feature-branch
2 checks passed
XKCD Comic RelifLink: https://xkcd.com/1843 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
* [SUBGRAPH] [BUG] PoolMember not getting updated when the member units change (#1877) * add a test starter * add the test * fixes * improve test * update dev container for matchstick compatibility * implement the fix * clean-up * add elaborate test for pool total amount received * fix test issue * add even more comments * fix test name * ignore test --------- Co-authored-by: 0xdavinchee <[email protected]> * [SUBGRAPH] approval mapping (#1878) * approval mapping * missing addresses * missing addresses cont. * no-op, trigger build * fix tests --------- Co-authored-by: Kaspar Kallas <[email protected]> * [subgraph] Fix Correctness of GDA Entities (#1890) --------- Co-authored-by: 0xdavinchee <[email protected]> * add createdAtTimestamp/BlockNumber for ATS entity (#1909) * [SUBGRAPH] fix governance config always null (#1908) * fix governance config always null * fix broken tests * [SUBGRAPH] fix resolver entry (#1843) * fix resolver entry * do resolver rpc call on token initialization and remove handleTokenRPCCalls in subsequent token calls * fix broken tests * TODO comment can be removed * remove mistakenly added files --------- Co-authored-by: 0xdavinchee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we move this:
resolverEntry.isToken = Token.load(target.toHex()) != null;out of theresolverEntry == nulland only update it if thetargetis not null.We need to do this because of sepolia where the token entity is created after the resolver set event is emitted (triggered), thus we want to be able to call set again and fix this. Edited: This makes ETHx not shown as listed in sepolia subgraph.