Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-core][sdk-redux] add GDA pool subgraph entity queries #1840

Merged

Conversation

kasparkallas
Copy link
Contributor

@kasparkallas kasparkallas commented Feb 23, 2024

Why?

The queries are already used in the Console. Moving these queries upstream. Will re-use them in the Dashboard.

Includes other small fixes and updated subgraph schema.

Copy link

github-actions bot commented Feb 23, 2024

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@kasparkallas kasparkallas changed the title [sdk-core & sdk-redux] [WIP] add GDA pool subgraph entity queries [WIP] [sdk-core & sdk-redux] add GDA pool subgraph entity queries Feb 28, 2024
@hellwolf hellwolf changed the title [WIP] [sdk-core & sdk-redux] add GDA pool subgraph entity queries [WIP] [sdk-core][sdk-redux] add GDA pool subgraph entity queries Mar 12, 2024
@hellwolf hellwolf marked this pull request as draft March 12, 2024 09:18
@hellwolf
Copy link
Contributor

Pending subgraph fix.

kasparkallas and others added 5 commits March 12, 2024 14:23
… change (#1877)

* add a test starter

* add the test

* fixes

* improve test

* update dev container for matchstick compatibility

* implement the fix

* clean-up

* add elaborate test for pool  total amount received

* fix test issue

* add even more comments

* fix test name

* ignore test

---------

Co-authored-by: 0xdavinchee <[email protected]>
* approval mapping

* missing addresses

* missing addresses cont.

* no-op, trigger build

* fix tests

---------

Co-authored-by: Kaspar Kallas <[email protected]>
@kasparkallas kasparkallas changed the base branch from dev to 2024-03-subgraph-gda-feature-branch March 20, 2024 13:21
Base automatically changed from 2024-03-subgraph-gda-feature-branch to dev March 26, 2024 12:03
@kasparkallas kasparkallas changed the title [WIP] [sdk-core][sdk-redux] add GDA pool subgraph entity queries [sdk-core][sdk-redux] add GDA pool subgraph entity queries Mar 26, 2024
@kasparkallas kasparkallas marked this pull request as ready for review March 26, 2024 13:09
Copy link
Contributor

@0xdavinchee 0xdavinchee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xdavinchee 0xdavinchee enabled auto-merge March 26, 2024 14:02
@0xdavinchee 0xdavinchee added this pull request to the merge queue Mar 26, 2024
Merged via the queue into dev with commit d58178f Mar 26, 2024
14 checks passed
@0xdavinchee 0xdavinchee deleted the sdk-core-and-redux-add-gda-pool-subgraph-entity-queries branch March 26, 2024 14:30
Copy link

XKCD Comic Relif

Link: https://xkcd.com/1840
https://xkcd.com/1840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants