-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk-core][sdk-redux] add GDA pool subgraph entity queries #1840
Merged
0xdavinchee
merged 19 commits into
dev
from
sdk-core-and-redux-add-gda-pool-subgraph-entity-queries
Mar 26, 2024
Merged
[sdk-core][sdk-redux] add GDA pool subgraph entity queries #1840
0xdavinchee
merged 19 commits into
dev
from
sdk-core-and-redux-add-gda-pool-subgraph-entity-queries
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
kasparkallas
changed the title
[sdk-core & sdk-redux] [WIP] add GDA pool subgraph entity queries
[WIP] [sdk-core & sdk-redux] add GDA pool subgraph entity queries
Feb 28, 2024
hellwolf
changed the title
[WIP] [sdk-core & sdk-redux] add GDA pool subgraph entity queries
[WIP] [sdk-core][sdk-redux] add GDA pool subgraph entity queries
Mar 12, 2024
Pending subgraph fix. |
… change (#1877) * add a test starter * add the test * fixes * improve test * update dev container for matchstick compatibility * implement the fix * clean-up * add elaborate test for pool total amount received * fix test issue * add even more comments * fix test name * ignore test --------- Co-authored-by: 0xdavinchee <[email protected]>
* approval mapping * missing addresses * missing addresses cont. * no-op, trigger build * fix tests --------- Co-authored-by: Kaspar Kallas <[email protected]>
--------- Co-authored-by: 0xdavinchee <[email protected]>
kasparkallas
changed the base branch from
dev
to
2024-03-subgraph-gda-feature-branch
March 20, 2024 13:21
…nch' into sdk-core-and-redux-add-gda-pool-subgraph-entity-queries
kasparkallas
changed the title
[WIP] [sdk-core][sdk-redux] add GDA pool subgraph entity queries
[sdk-core][sdk-redux] add GDA pool subgraph entity queries
Mar 26, 2024
hellwolf
reviewed
Mar 26, 2024
hellwolf
reviewed
Mar 26, 2024
0xdavinchee
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0xdavinchee
deleted the
sdk-core-and-redux-add-gda-pool-subgraph-entity-queries
branch
March 26, 2024 14:30
XKCD Comic RelifLink: https://xkcd.com/1840 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The queries are already used in the Console. Moving these queries upstream. Will re-use them in the Dashboard.
Includes other small fixes and updated subgraph schema.