[ETHEREUM-CONTRACTS] CFASuperAppBase renamed, made compatible with factory and proxy patterns #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…factory and proxy pattern
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
hellwolf
approved these changes
Feb 21, 2024
XKCD Comic RelifLink: https://xkcd.com/1838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous name was misleading, as the base contract is specifically about the CFA.
The previous version assumed SuperApps to be deployed by a whitelisted EOA, using the now deprecated
host.registerAppWithKey. Now self-registration is optional, so it can also be used with a factory pattern (whitelisted deployer contract).The previous version wouldn't work for logic contracts in the context of a proxy pattern, thus initialization was split between constructor (just setting an immutable host) and an initialize function doing the rest.