Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WORKFLOWS] make sure linting happens in more places #1824

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

hellwolf
Copy link
Contributor

@hellwolf hellwolf commented Feb 6, 2024

No description provided.

@hellwolf hellwolf enabled auto-merge February 6, 2024 12:34
Copy link

github-actions bot commented Feb 6, 2024

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@hellwolf hellwolf added this pull request to the merge queue Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a73abf) 74.30% compared to head (d541155) 74.30%.
Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1824   +/-   ##
=======================================
  Coverage   74.30%   74.30%           
=======================================
  Files         109      109           
  Lines        5884     5884           
  Branches      216      216           
=======================================
  Hits         4372     4372           
  Misses       1460     1460           
  Partials       52       52           
Flag Coverage Δ
ethereum-contracts 65.54% <ø> (ø)
sdk-core 82.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into dev with commit 29fbc58 Feb 6, 2024
21 checks passed
@hellwolf hellwolf deleted the fix-strict-lint-in-ci branch February 6, 2024 15:05
Copy link

github-actions bot commented Feb 6, 2024

XKCD Comic Relif

Link: https://xkcd.com/1824
https://xkcd.com/1824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants