Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert BatchLiquidator #1817

Closed
wants to merge 2 commits into from
Closed

Revert BatchLiquidator #1817

wants to merge 2 commits into from

Conversation

ngmachado
Copy link
Contributor

This PR revert the BatchLiquidator to a working version.

  • Sentinel was not update for this version, but uses monorepo abi. (broke L2)
  • Sentinel split CFA / GDA in different processes. At this time the changes would only consume more gas

@ngmachado ngmachado requested a review from d10r January 30, 2024 16:26
@github-actions GitHub Actions
Copy link

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@hellwolf hellwolf marked this pull request as draft January 31, 2024 10:20
@ngmachado ngmachado closed this Jan 31, 2024
@ngmachado ngmachado deleted the revert_batch branch February 11, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellwolf hellwolf Awaiting requested review from hellwolf hellwolf is a code owner

@0xdavinchee 0xdavinchee Awaiting requested review from 0xdavinchee

@d10r d10r Awaiting requested review from d10r d10r is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngmachado @d10r