Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETHEREUM-CONTRACTS] Forked truffle-plugin-verify so we can verify the new networks #1797

Merged
merged 9 commits into from
Jan 22, 2024

Conversation

d10r
Copy link
Collaborator

@d10r d10r commented Jan 22, 2024

eventually we need to migrate away, but for now we need a short-term fix for the new networks, which is to use a fork of the plugin.

Copy link

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@d10r d10r changed the title Forked truffle plugin verify [ETHEREUM-CONTRACTS] Forked truffle-plugin-verify so we can verify the new networks Jan 22, 2024
@d10r d10r marked this pull request as ready for review January 22, 2024 17:13
@d10r d10r requested review from hellwolf, 0xdavinchee and a team as code owners January 22, 2024 17:13
@d10r d10r enabled auto-merge January 22, 2024 17:13
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ec1e21) 74.45% compared to head (dad9809) 74.45%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1797   +/-   ##
=======================================
  Coverage   74.45%   74.45%           
=======================================
  Files         109      109           
  Lines        5873     5873           
  Branches      216      216           
=======================================
  Hits         4373     4373           
  Misses       1450     1450           
  Partials       50       50           
Flag Coverage Δ
ethereum-contracts 65.53% <ø> (ø)
sdk-core 82.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hellwolf
Copy link
Contributor

Keep truffle alive! :D

@d10r d10r added this pull request to the merge queue Jan 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@d10r d10r force-pushed the forked-truffle-plugin-verify branch from 3a5b9a2 to dad9809 Compare January 22, 2024 20:14
@d10r d10r enabled auto-merge January 22, 2024 20:16
@d10r d10r added this pull request to the merge queue Jan 22, 2024
Merged via the queue into dev with commit 64cb27a Jan 22, 2024
21 checks passed
@d10r d10r deleted the forked-truffle-plugin-verify branch January 22, 2024 22:15
Copy link

XKCD Comic Relif

Link: https://xkcd.com/1797
https://xkcd.com/1797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants