Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scroll Sepolia and Mainnet #1785

Closed
wants to merge 4 commits into from

Conversation

isabellewei
Copy link

@isabellewei isabellewei commented Jan 18, 2024

  • add Scroll network configs
  • update metadata with deployed addresses

@@ -420,6 +435,7 @@ const E = (module.exports = {
celoscan: process.env.CELOSCAN_API_KEY,
basescan: process.env.BASESCAN_API_KEY,
zkevm_polygonscan: process.env.ZKEVM_POLYGONSCAN_API_KEY,
scrollscan: process.env.SCROLLSCAN_API_KEY,
Copy link
Collaborator

@d10r d10r Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this won't work unless we fork https://github.com/rkalis/truffle-plugin-verify and add support (which fortunately wouldn't be difficult though, see e.g. rkalis/truffle-plugin-verify@b2d8860).

Copy link

📦 PR Packages

Install this PR (you need to setup Github packages):

yarn add @superfluid-finance/ethereum-contracts@PR1785
yarn add @superfluid-finance/sdk-core@PR1785
yarn add @superfluid-finance/sdk-redux@PR1785
:octocat: Click to learn how to use Github packages

To use the Github package registry, create a token with "read:packages" permission. See Creating a personal access token for help.

Next add these lines to your .npmrc file, replacing TOKEN with your personal access token. See Installing a package from Github if you get stuck.

@superfluid-finance:registry=https://npm.pkg.github.com
//npm.pkg.github.com/:_authToken=TOKEN

@hellwolf
Copy link
Contributor

@d10r some conflict to resolve in metadata.

@d10r
Copy link
Collaborator

d10r commented Jan 22, 2024

this was merged through #1787, thx @isabellewei !

@d10r d10r closed this Jan 22, 2024
@hellwolf
Copy link
Contributor

@all-contributors please add @isabellewei for code!

Copy link
Contributor

@hellwolf

I've put up a pull request to add @isabellewei! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants