Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[METADATA] base goerli cliName added + bumped versions all around #1759

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

0xdavinchee
Copy link
Contributor

No description provided.

Copy link

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

Copy link
Collaborator

@d10r d10r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing CI runs, but seems unrelated to the changes

@d10r d10r enabled auto-merge December 18, 2023 12:21
@d10r d10r added this pull request to the merge queue Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4065973) 88.64% compared to head (7bfe27f) 88.62%.
Report is 5 commits behind head on dev.

Files Patch % Lines
...ackages/sdk-core/src/mapGetAllEventsQueryEvents.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1759      +/-   ##
==========================================
- Coverage   88.64%   88.62%   -0.02%     
==========================================
  Files          95       95              
  Lines        4692     4693       +1     
  Branches      194      194              
==========================================
  Hits         4159     4159              
- Misses        486      487       +1     
  Partials       47       47              
Flag Coverage Δ
ethereum-contracts 97.74% <ø> (ø)
sdk-core 80.77% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into dev with commit b6c220a Jan 8, 2024
19 of 21 checks passed
@d10r d10r deleted the metadata-fix branch January 8, 2024 10:46
Copy link

github-actions bot commented Jan 8, 2024

XKCD Comic Relif

Link: https://xkcd.com/1759
https://xkcd.com/1759

hellwolf added a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants