Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETHEREUM-CONTRACTS] use eip 1967 slot for admin #1710

Merged
merged 3 commits into from
Oct 4, 2023
Merged

[ETHEREUM-CONTRACTS] use eip 1967 slot for admin #1710

merged 3 commits into from
Oct 4, 2023

Conversation

0xdavinchee
Copy link
Contributor

No description provided.

@0xdavinchee 0xdavinchee added Tag: TechDebt Technical debt that needs to be addressed Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps labels Oct 3, 2023
@0xdavinchee 0xdavinchee self-assigned this Oct 3, 2023
@0xdavinchee 0xdavinchee requested a review from hellwolf as a code owner October 3, 2023 14:47
@0xdavinchee 0xdavinchee linked an issue Oct 3, 2023 that may be closed by this pull request
[ETHEREUM-CONTRACTS] Use EIP-1967 Admin Proxy #1709
Closed
@github-actions
Copy link

github-actions bot commented Oct 3, 2023 •
edited by 0xdavinchee
Loading

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@0xdavinchee 0xdavinchee requested a review from d10r October 4, 2023 07:07
@hellwolf hellwolf removed the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Oct 4, 2023
@hellwolf hellwolf added this pull request to the merge queue Oct 4, 2023
Merged via the queue into dev with commit c10bd28 Oct 4, 2023
18 checks passed
@hellwolf hellwolf deleted the 1709-eip-1967-admin-slot branch October 4, 2023 12:47
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

XKCD Comic Relif

Link: https://xkcd.com/1710
https://xkcd.com/1710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellwolf hellwolf hellwolf approved these changes

@d10r d10r Awaiting requested review from d10r d10r is a code owner

Assignees

@0xdavinchee 0xdavinchee

Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Tag: TechDebt Technical debt that needs to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ETHEREUM-CONTRACTS] Use EIP-1967 Admin Proxy
2 participants
@0xdavinchee @hellwolf