[TECHDEBT][ETHEREUM-CONTRACTS] Remove token info #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xdavinchee
added
Tag: TechDebt
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
hellwolf
reviewed
Sep 18, 2023
| @@ -4,7 +4,7 @@ | |||
| "UUPSProxiable", | |||
| "IERC20", | |||
| "IERC777", | |||
| "TokenInfo", "ERC20WithTokenInfo", | |||
| "IERC20Metadata", | |||
There was a problem hiding this comment.
a breaking change that's need to be documented in CHANGELOG.
hellwolf
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Revise changelog for this breaking change.
Fwiw: here are the internal references to it: https://github.com/search?q=org%3Asuperfluid-finance%20ERC20WithTokenInfo&type=code
hellwolf
reviewed
Sep 18, 2023
hellwolf
approved these changes
Sep 18, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## dev #1679 +/- ##
=======================================
Coverage 88.28% 88.28%
=======================================
Files 90 90
Lines 4448 4448
Branches 186 186
=======================================
Hits 3927 3927
Misses 475 475
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
XKCD Comic RelifLink: https://xkcd.com/1679 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.