[ETHEREUM-CONTRACTS] | #1038 | Allow regular contracts to be the target of callAppAction #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove isAppActive modifier from `Superfluid.sol` and `ISuperfluid.sol` - remove `HOST_NOT_A_SUPER_APP` and `HOST_SUPER_APP_IS_JAILED` custom errors - create new `NonSuperAppContractMock.sol` to test `callAppAction` and `callAppActionWithContext` on a non-super app contract - Add two functions to `SuperAppMocks` to test `callAppActionWithContext` on our non-superApp contract
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
hellwolf
added
the
Tag: Idea
|
closing this PR for now as this is stale and nobody is asking for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation: To relax the requirement that
callAppActioncan only be used on super app contracts.Context: This change allows all contracts to be the target of
callAppActionas long as thefunctionon the contract satisfies two requirements:functionyou want to call viacallAppActionmust takebytes(the passed context from the host) as the last parameter.function, that is, untouched.This was achieved simply by deleting the
isAppActivemodifier fromSuperfluid.sol,ISuperfluid.soland any associated custom errors only used by this modifer.Issue: #1038
Type of change
How Has This Been Tested?
I have added tests to ensure that non-super app contracts can be the target of
callAppActionandcallAppActionWithContext.callAppActionreverting when passing invalid calldatacallAppActionreverting when an EOA is the target, ctx is malformatted because bytes returned is "0x"callAppActioncallAppActionWithContextcallAppActionWithContextgiven that we ignore the context passed by the host via the initialcallAppActionand pass in our own context