[ETHEREUM-CONTRACTS] | #1038 | Allow regular contracts to be the target of callAppAction

[0xdavinchee]

Description

Motivation: To relax the requirement that callAppAction can only be used on super app contracts.

Context: This change allows all contracts to be the target of callAppAction as long as the function on the contract satisfies two requirements:

1. The function you want to call via callAppAction must take bytes (the passed context from the host) as the last parameter.
2. You must return the "correct" context bytes from the contract in the function, that is, untouched.

NOTE: this means that EOAs cannot be targets of callAppAction as any call against an EOA returns empty bytes.

This was achieved simply by deleting the isAppActive modifier from Superfluid.sol, ISuperfluid.sol and any associated custom errors only used by this modifer.

Issue: #1038

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I have added tests to ensure that non-super app contracts can be the target of callAppAction and callAppActionWithContext.

• 8.1-8.3 tests callAppAction reverting when passing invalid calldata
• 8.4 tests callAppAction reverting when an EOA is the target, ctx is malformatted because bytes returned is "0x"
• 8.5.0 tests a revert given requirement 1 failing
• 8.5.1 tests a revert given requirement 1 passing, but requirement 2 failing (returning empty bytes)
• 8.5.2 tests happy path callAppAction
• 8.5.3 tests happy path callAppActionWithContext
• 8.5.4 tests a revert callAppActionWithContext given that we ignore the context passed by the host via the initial callAppAction and pass in our own context

[github-actions]

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

• CHANGELOG.md modified
• Double check before merge

[hellwolf]

Contract A

** foo (app action)
[a] Mostly likely foo should check if msg.sender == host.
[b] currently needs A to be whitelisted, in order to get correct msgSender.
[c*] foo calls callAgreement should fail due to ctx not clean.
[d*] foo calls callAgreementWithCtx should also fail due to app level restriction.

[hellwolf]

let's also ban calling this (the host contract itself) as target.

[hellwolf]

also remove the ISuperApp type, and call app e.g. "target"

[0xdavinchee]

closing this PR for now