workflow: make node22 default and testing 18,20,22

superfluid-finance · Aug 29, 2024 · b40312f · b40312f
1 parent f7dfa9e
commit b40312f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/flake.nix b/flake.nix
@@ -156,15 +156,19 @@
     devShells.mk-cache-key = mkShell {
       buildInputs = [ mk-cache-key-pkg ];
     };
+
     devShells.ci-minimum = mkShell {
-      buildInputs = ciInputs ++ commonDevInputs;
+      buildInputs = with pkgs; ciInputs ++ [ actionlint shellcheck ];
     };
+
     devShells.ci-default = mkShellForNodeCI defaultNodeDevInputs;
     devShells.ci-node18 = mkShellForNodeCI node18DevInputs;
-    devShells.ci-node20 = mkShellForSpecCI node20DevInputs;
-    devShells.ci-node22 = mkShellForSpecCI node22DevInputs;
+    devShells.ci-node20 = mkShellForNodeCI node20DevInputs;
+    devShells.ci-node22 = mkShellForNodeCI node22DevInputs;
+
     devShells.ci-spec-ghc92 = mkShellForSpecCI ghcVer92;
     devShells.ci-spec-ghc94 = mkShellForSpecCI ghcVer94;
+
     devShells.ci-hot-fuzz = mkShell {
       buildInputs = with pkgs; ciInputs ++ commonDevInputs ++ ethDevInputs ++ [
         slither-analyzer

diff --git a/packages/ethereum-contracts/README.md b/packages/ethereum-contracts/README.md
@@ -35,7 +35,7 @@ If you're building a smart contract that uses Superfluid protocol, or even your
 ### Installation
 
 Prerequisites:
-- [node.js v18+](https://nodejs.org/en/download)
+- [node.js v18+](https://nodejs.org/en/download). The project recommends 22, and is tested with node 18,20,22.
 - [yarn](https://classic.yarnpkg.com/en/docs/install)
 - [forge](https://book.getfoundry.sh/getting-started/installation)