fix breaking build + address comments

superfluid-finance · Sep 21, 2023 · 89e742a · 89e742a
1 parent bf4b968
commit 89e742a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/ethereum-contracts/contracts/mocks/SuperTokenMock.sol b/packages/ethereum-contracts/contracts/mocks/SuperTokenMock.sol
@@ -59,6 +59,9 @@ contract SuperTokenStorageLayoutTester is SuperToken {
         require (slot == 18 && offset == 0, "_operators changed location");
         // uses 4 slots
 
+        assembly { slot:= _adminOverride.slot offset := _adminOverride.offset }
+        require (slot == 22 && offset == 0, "_adminOverride changed location");
+
         assembly { slot:= _reserve23.slot offset := _reserve23.offset }
         require (slot == 23 && offset == 0, "_reserve23 changed location");
 

diff --git a/packages/ethereum-contracts/test/foundry/superfluid/Superfluid.t.sol b/packages/ethereum-contracts/test/foundry/superfluid/Superfluid.t.sol
@@ -70,10 +70,9 @@ contract SuperfluidIntegrationTest is FoundrySuperfluidTester {
         vm.stopPrank();
 
         vm.startPrank(address(sf.governance));
+        vm.expectRevert(ISuperToken.SUPER_TOKEN_ONLY_ADMIN.selector);
         sf.host.changeSuperTokenAdmin(superToken, newAdmin);
         vm.stopPrank();
-
-        assertEq(superToken.getAdminOverride().admin, newAdmin, "Superfluid.t: super token admin not changed");
     }
 
     function testRevertChangeSuperTokenAdminWhenNotGovernanceCalling(address newAdmin) public {