Merge branch 'dev' into metadata-fix

superfluid-finance · Jan 5, 2024 · 7bfe27f · 7bfe27f
2 parents dfa536a + 1bf8e7c
commit 7bfe27f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/sdk-core/src/events.ts b/packages/sdk-core/src/events.ts
@@ -436,5 +436,6 @@ export interface BondIncreasedEvent extends EventBase {
 }
 
 export interface UnknownEvent extends EventBase {
-    name: string;
+    // @note using the string type breaks the type guard
+    name: "";
 }
diff --git a/packages/sdk-core/src/mapGetAllEventsQueryEvents.ts b/packages/sdk-core/src/mapGetAllEventsQueryEvents.ts
@@ -680,7 +680,8 @@ export const mapGetAllEventsQueryEvents = (
                     `An unknown event [${eventBase.name}] was detected which couldn't be properly mapped. Please update to the latest version of @superfluid-finance/sdk-core.`
                 );
                 return typeGuard<events.UnknownEvent>({
-                    name: eventBase.name,
+                    // force casted as empty string for the type system
+                    name: eventBase.name as "",
                     id: eventBase.id,
                     blockNumber: eventBase.blockNumber,
                     transactionHash: eventBase.transactionHash,