Replace to HTTPTypes.HTTPRequest from Helpers.HTTPRequest #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Helpers.HTTPRequest and Helpers.HTTPResponse
|
Thanks for taking the leap on this @zunda-pixel. We're not in the stage on having breaking changes at the moment, I'm planning a v3 for next couple of months, breaking changes will have to wait until then. For now, we need to make sure changes are retro-compatible. |
|
Ok, I am looking forward to v3. |
|
Yes @zunda-pixel , that is the branch. There are basically 3 issues that I want to fix yet on v2 before I move focus to v3, they are these ones: https://github.com/supabase/supabase-swift/issues?q=is%3Aopen+is%3Aissue+milestone%3Av2 |
# Conflicts: # Sources/Auth/AuthError.swift # Sources/Auth/Internal/APIClient.swift # Sources/Auth/Internal/Contants.swift # Sources/Auth/Internal/SessionManager.swift # Sources/Helpers/URLSession+AsyncAwait.swift # Sources/Helpers/Version.swift # Sources/Storage/MultipartFormData.swift # Sources/Storage/StorageFileApi.swift # Tests/AuthTests/SessionManagerTests.swift # Tests/IntegrationTests/StorageFileIntegrationTests.swift # Tests/StorageTests/SupabaseStorageTests.swift
zunda-pixel
force-pushed
the
replace-HTTPRequest
branch
from
00e9ef9
to
6617fc1
Compare
|
@grdsdev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace to HTTPTypes's Components.
Breaking Changes
Copyright
URLSession for HTTPRequest(URLSession+AsyncAwait.swift) code from apple/swift-http-types
We need this code until update to Swift 6