Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): syncing for postgres hook without secrets #2931

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

avallete
Copy link
Member

What kind of change does this PR introduce?

  • Postgres custom auth hook doesn't have any secret value, this is only required for http endpoint. We turn the secret into an optional value in the config structure so it can be omitted in such case rather than being filled with an empty string.

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@coveralls
Copy link

coveralls commented Nov 29, 2024

Pull Request Test Coverage Report for Build 12113515963

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.583%

Totals Coverage Status
Change from base Build 12080272861: 0.0%
Covered Lines: 6401
Relevant Lines: 10743

💛 - Coveralls

@sweatybridge
Copy link
Contributor

Could you elaborate again why empty string was causing an issue?

Copy link
Contributor

@sweatybridge sweatybridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for nitpicking. We want to be extremely strict about the coding standards for these configs. The impact of large frequent changes is very bad on cognitive load as well as maintainability, especially since we've spent a lot of time crafting it carefully.

pkg/config/auth_test.go Outdated Show resolved Hide resolved
pkg/config/auth_test.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/auth.go Outdated Show resolved Hide resolved
@avallete
Copy link
Member Author

Sorry for nitpicking. We want to be extremely strict about the coding standards for these configs. The impact of large frequent changes is very bad on cognitive load as well as maintainability, especially since we've spent a lot of time crafting it carefully.

No worries thank's for the thorough review, I've changed the code accordingly to your comments.

@sweatybridge sweatybridge merged commit 2ff5960 into develop Dec 2, 2024
13 checks passed
@sweatybridge sweatybridge deleted the fix/custom-auth-hook-pg-functions branch December 2, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants