Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add minimum password length and password requirements config #2885

Conversation

silentworks
Copy link
Contributor

What kind of change does this PR introduce?

This feature can be found in the Supabase Hosted Dashboard but doesn't have a way to configure it in the config.toml.

What is the current behavior?

No way to set Password minimum length and Password requirements

What is the new behavior?

Can now set Password minimum length and Password requirements in the config.toml file.

Additional context

Add any other context or screenshots.

pkg/config/auth.go Outdated Show resolved Hide resolved
pkg/config/templates/config.toml Outdated Show resolved Hide resolved
pkg/config/auth.go Outdated Show resolved Hide resolved
@silentworks
Copy link
Contributor Author

Add screen recording to show this working.

Turn down your audio as I might be a bit loud in the recording.

supabase_cli_min_pass_and_pass_req.mp4

@coveralls
Copy link

coveralls commented Nov 26, 2024

Pull Request Test Coverage Report for Build 12068378695

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 59.583%

Files with Coverage Reduction New Missed Lines %
internal/start/start.go 14 68.49%
Totals Coverage Status
Change from base Build 12029272052: 0.01%
Covered Lines: 6401
Relevant Lines: 10743

💛 - Coveralls

@sweatybridge sweatybridge merged commit b9e0aa0 into supabase:develop Nov 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants